Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Copyright Headers #522

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Update Copyright Headers #522

merged 1 commit into from
Apr 8, 2024

Conversation

prashantrewar
Copy link
Contributor

Fixes #521

@praveenrewar
Copy link
Member

@prashantrewar Could you also update the copyright year regex in the golangci yaml. (Like this

@prashantrewar
Update Copyright Headers
1d918c9 
Signed-off-by: Prashant Rewar <[email protected]>
@prashantrewar prashantrewar force-pushed the update-copyright-headers branch from e13215c to 1d918c9 Compare April 6, 2024 18:37
@prashantrewar
Copy link
Contributor Author

@prashantrewar Could you also update the copyright year regex in the golangci yaml. (Like this

@praveenrewar, Done!

praveenrewar
praveenrewar approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar merged commit 972ca72 into carvel-dev:develop Apr 8, 2024
5 checks passed
@prashantrewar prashantrewar deleted the update-copyright-headers branch April 8, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update copyright headers
2 participants
@prashantrewar @praveenrewar